Skip to content

chore: improve translation string management #6502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 5, 2025
Merged

chore: improve translation string management #6502

merged 1 commit into from
Oct 5, 2025

Conversation

@philmoz
Copy link
Collaborator

@philmoz philmoz commented Aug 7, 2025

Key changes:

  • Cleanup string usage. Remove all direct usage of TR_xxx strings, always use STR_xxx version. Changes to the translation files no longer require re-compiling almost every other file.
  • Add translation testing to tests build. Test all language translation files against the English base when running the 'tests' target. Issues with translation files can be caught during build.
  • Remove conditional sections, and string array definitions from the translation files. This simplifies the files as each line is a single string to translate. Ensures string arrays always have the correct number of entries.
  • Restructure 'translations' folder. Group translation and tts source files into sub folders. Move all translation related files into the translations folder.
  • Easier addition of new strings. Edit a single file (string_list.h) instead of modifying multiple files.

Note: based on 3.0UI PR.

@philmoz philmoz added this to the 3.0 milestone Aug 7, 2025
@philmoz philmoz added compilation Related to compiling the firmware and firmware options house keeping 🧹 Cleanup of code and house keeping labels Aug 7, 2025
@philmoz philmoz force-pushed the philmoz/string-cleaning branch from 0588b0d to f6bf416 Compare August 9, 2025 09:32
@philmoz philmoz force-pushed the philmoz/string-cleaning branch from f6bf416 to 70beb83 Compare August 11, 2025 22:18
@philmoz philmoz force-pushed the philmoz/string-cleaning branch from 70beb83 to 89aff45 Compare August 12, 2025 08:08
@philmoz philmoz force-pushed the philmoz/string-cleaning branch 2 times, most recently from 0bdf2f0 to f943513 Compare September 13, 2025 20:48
@philmoz philmoz force-pushed the 3_0_ui branch 2 times, most recently from 2de871d to 0c4c5ab Compare September 19, 2025 03:01
@philmoz philmoz force-pushed the philmoz/string-cleaning branch from f943513 to b41e5b7 Compare September 19, 2025 06:22
@philmoz philmoz force-pushed the philmoz/string-cleaning branch from 4127669 to 6a1d150 Compare September 20, 2025 05:20
@philmoz philmoz force-pushed the 3_0_ui branch 3 times, most recently from b7520b6 to 7377662 Compare October 1, 2025 09:36
Base automatically changed from 3_0_ui to main October 2, 2025 03:12
@philmoz philmoz force-pushed the philmoz/string-cleaning branch from 6a1d150 to 09a2806 Compare October 2, 2025 03:42
Cleanup string usage.
3561913 
Add translation testing to tests build.
Remove conditional sections from translation files.
Restructure 'translations' folder.
@philmoz philmoz force-pushed the philmoz/string-cleaning branch from 3e268e4 to 3561913 Compare October 4, 2025 05:39
@philmoz
Copy link
Collaborator Author

philmoz commented Oct 4, 2025

@pfeerick Could this be merged before any more big translation file updates please.

@pfeerick
Copy link
Member

pfeerick commented Oct 5, 2025

Yup, and thanks for answering the question of "which PR do you prefer first (now that the base 3.0 UI PR is in)?" before I asked it 😆

@pfeerick pfeerick merged commit 6a37b3d into main Oct 5, 2025
47 checks passed
@pfeerick pfeerick deleted the philmoz/string-cleaning branch October 5, 2025 03:04
@pfeerick pfeerick mentioned this pull request Oct 10, 2025
Open
1 task
@3djc 3djc mentioned this pull request Oct 11, 2025
Closed
1 task
@philmoz philmoz mentioned this pull request Oct 11, 2025
Merged
@pfeerick pfeerick mentioned this pull request Oct 18, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

compilation Related to compiling the firmware and firmware options house keeping 🧹 Cleanup of code and house keeping

Projects

None yet

Milestone

3.0

Development

Successfully merging this pull request may close these issues.

3 participants

@philmoz @pfeerick